Issue 880573005: Revert of Use data_deps rather then deps for mojo_bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 880573005: Revert of Use data_deps rather then deps for mojo_bindings. (Closed)

Created:
5 years, 10 months ago by dconnelly

Modified:
5 years, 10 months ago

Reviewers:
Dirk Pranke, brettw, Slava Chigrin

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Use data_deps rather then deps for mojo_bindings. (patchset #1 id:1 of https://codereview.chromium.org/876783003/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=452847 Original issue's description: > Use data_deps rather then deps for mojo_bindings. > > Using deps caused pulling a bit of mojo code to chrome.exe. That > caused weird unresolved externatls problems during Windows GN build. > > Committed: https://crrev.com/f7b4f01989be22df44d9b5475143ef98b653b1ac > Cr-Commit-Position: refs/heads/master@{#313126} TBR=brettw@chromium.org,dpranke@chromium.org,vchigrin@yandex-team.ru NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/49911f06fc1d061a4b7e61e1811fe303b5ef0cd2 Cr-Commit-Position: refs/heads/master@{#313492}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	build/secondary/tools/grit/grit_rule.gni	View		2 chunks	+0 lines, -4 lines	0 comments	Download
	M	chrome/browser/BUILD.gn	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

dconnelly

Created Revert of Use data_deps rather then deps for mojo_bindings.

5 years, 10 months ago (2015-01-28 12:59:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880573005/1

5 years, 10 months ago (2015-01-28 13:00:35 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-01-28 13:02:35 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/49911f06fc1d061a4b7e61e1811fe303b5ef0cd2
Cr-Commit-Position: refs/heads/master@{#313492}