Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 880573002: ui_touch_selection_unittests.isolate: Don't bundle osmesa on Win and Mac. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui_touch_selection_unittests.isolate: Don't bundle osmesa on Win and Mac. The build target doesn't depend on it, so there's a chance that the file doesn't exist yet when the isolate step runs. Since it kind of looks like this is only here due to a copy-paste error, removing the file from the isolate rather than adding a dependency. BUG=98637 Committed: https://crrev.com/3dc33bd5214a94b2f206950980b09bf6218eec7e Cr-Commit-Position: refs/heads/master@{#313293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M ui/touch_selection/ui_touch_selection_unittests.isolate View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
\noideanico{}
5 years, 11 months ago (2015-01-26 17:18:09 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-27 09:55:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880573002/1
5 years, 11 months ago (2015-01-27 17:13:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 17:17:12 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 17:18:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dc33bd5214a94b2f206950980b09bf6218eec7e
Cr-Commit-Position: refs/heads/master@{#313293}

Powered by Google App Engine
This is Rietveld 408576698