Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 880533004: [sql] Fix CRLF in some SQLite source code. (Closed)

Created:
5 years, 10 months ago by Scott Hess - ex-Googler
Modified:
5 years, 10 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Fix CRLF in some SQLite source code. Sometimes CRLF sneak into SQLite's code, and then causes patch errors when landing in Chromium. Add an import step for cleaning this up and clean things up. None of these files are in the Chromium build. They just gum up the works. BUG=340757 TBR=michaeln@chromium.org NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/64ce04c6c0caa5aae0eb0f6eac7a7512f688b996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -364 lines) Patch
M third_party/sqlite/README.chromium View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/sqlite/sqlite-src-3070603/src/test_func.c View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/sqlite/sqlite-src-3070603/test/enc4.test View 1 chunk +139 lines, -139 lines 0 comments Download
M third_party/sqlite/sqlite-src-3070603/test/fts3snippet.test View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/sqlite/sqlite-src-3070603/test/tkt-3fe897352e.test View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/sqlite/sqlite-src-3070603/tool/restore_jrnl.tcl View 1 chunk +31 lines, -31 lines 0 comments Download
M third_party/sqlite/src/src/test_func.c View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/sqlite/src/test/enc4.test View 1 chunk +139 lines, -139 lines 0 comments Download
M third_party/sqlite/src/test/fts3snippet.test View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/sqlite/src/test/tkt-3fe897352e.test View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/sqlite/src/tool/restore_jrnl.tcl View 1 chunk +31 lines, -31 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Scott Hess - ex-Googler
Other change was failing because of CRLF conflicts in patching. This is all CRLF->LF changes, ...
5 years, 10 months ago (2015-01-30 23:15:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880533004/1
5 years, 10 months ago (2015-01-30 23:17:08 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/54100) ios_rel_device_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/6044) ios_rel_device_ninja_ng ...
5 years, 10 months ago (2015-01-30 23:20:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880533004/1
5 years, 10 months ago (2015-01-30 23:30:28 UTC) #8
commit-bot: I haz the power
Failed to apply patch for third_party/sqlite/sqlite-src-3070603/src/test_func.c: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-01-30 23:31:20 UTC) #10
Scott Hess - ex-Googler
On 2015/01/30 23:31:20, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
5 years, 10 months ago (2015-01-30 23:51:50 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/64ce04c6c0caa5aae0eb0f6eac7a7512f688b996 Cr-Commit-Position: refs/heads/master@{#314033}
5 years, 10 months ago (2015-01-31 00:03:10 UTC) #13
Scott Hess - ex-Googler
5 years, 10 months ago (2015-01-31 00:03:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
64ce04c6c0caa5aae0eb0f6eac7a7512f688b996 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698