Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 880533002: [turbofan] Simplify reduction if IfTrue and IfFalse and fix bugs. (Closed)

Created:
5 years, 11 months ago by titzer
Modified:
5 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Simplify reduction if IfTrue and IfFalse and fix bugs. R=mstarzinger@chromium.org BUG=chromium:451958 LOG=Y Committed: https://crrev.com/7c81161b97504caedc93b01fa984791e9fb302c3 Cr-Commit-Position: refs/heads/master@{#26276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -51 lines) Patch
M src/compiler/control-reducer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/control-reducer.cc View 3 chunks +37 lines, -27 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 7 chunks +28 lines, -23 lines 0 comments Download
A test/mjsunit/regress/regress-451958.js View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
titzer
5 years, 11 months ago (2015-01-26 15:24:53 UTC) #1
Michael Starzinger
LGTM.
5 years, 11 months ago (2015-01-26 15:28:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880533002/1
5 years, 11 months ago (2015-01-26 15:42:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/195)
5 years, 11 months ago (2015-01-26 15:44:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880533002/1
5 years, 11 months ago (2015-01-26 15:50:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 16:11:22 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 16:11:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c81161b97504caedc93b01fa984791e9fb302c3
Cr-Commit-Position: refs/heads/master@{#26276}

Powered by Google App Engine
This is Rietveld 408576698