Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 88053002: Implement Math.ceil via Math.floor. (Closed)

Created:
7 years ago by Sven Panne
Modified:
7 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Implement Math.ceil via Math.floor. This way we get all the Crankshaft goodness and avoid always going through the runtime: Less code + even some small speedup in Kraken. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=18072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M src/math.js View 2 chunks +2 lines, -1 line 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/v8-counters.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
7 years ago (2013-11-26 12:09:38 UTC) #1
Jakob Kummerow
LGTM. You're lucky this works out for -0 ;-)
7 years ago (2013-11-26 12:26:32 UTC) #2
Sven Panne
On 2013/11/26 12:26:32, Jakob wrote: > LGTM. You're lucky this works out for -0 ;-) ...
7 years ago (2013-11-26 12:29:27 UTC) #3
Sven Panne
7 years ago (2013-11-26 12:29:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18072 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698