chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json - Issue 880523005: [Extensions] Simplify Extension Keybinding API Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json

Issue 880523005: [Extensions] Simplify Extension Keybinding API Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/keybinding/basics/background.js ('K') | « chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js ('k') | chrome/test/data/extensions/api_test/keybinding/overwrite_bookmark_shortcut/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json

diff --git a/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json b/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json

index cc1345f5cb1a571886e7b090a6a39113d499bf0b..2cd7b98523d22467cd90e49b7e382ba5a97a6ed4 100644

--- a/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json

+++ b/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json

@@ -7,17 +7,17 @@

"permissions": ["activeTab"],

"commands": {

- "red": {

+ "ctrl_f": {

"suggested_key": "Ctrl+F",

- "description": "Make the page red"

+ "description": "Send a ctrl f test message"

- "green": {

+ "ctrl_d": {

"suggested_key": "Ctrl+D",

- "description": "Make the page green"

+ "description": "Send a ctrl d test message"

- "blue": {

+ "alt_shift_f": {

"suggested_key": "Alt+Shift+F",

- "description": "Make the page blue"

+ "description": "Send a ctrl shift f test message"

}