Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 880483003: Add types.MatchesWithIngores(). (Closed)

Created:
5 years, 10 months ago by jcgregorio
Modified:
5 years, 10 months ago
Reviewers:
stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add types.MatchesWithIngores(). BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/3adebd8c466918b2e7a8b236d0fbd9484a177e88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M perf/go/types/types.go View 1 chunk +14 lines, -0 lines 0 comments Download
M perf/go/types/types_test.go View 2 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jcgregorio
5 years, 10 months ago (2015-02-03 20:16:27 UTC) #2
stephana
On 2015/02/03 20:16:27, jcgregorio wrote: Looks ok, but if the intended usecase is to filter ...
5 years, 10 months ago (2015-02-03 21:55:40 UTC) #3
jcgregorio
On 2015/02/03 21:55:40, stephana wrote: > On 2015/02/03 20:16:27, jcgregorio wrote: > > Looks ok, ...
5 years, 10 months ago (2015-02-03 22:00:42 UTC) #4
stephana
On 2015/02/03 22:00:42, jcgregorio wrote: > On 2015/02/03 21:55:40, stephana wrote: > > On 2015/02/03 ...
5 years, 10 months ago (2015-02-03 22:05:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880483003/1
5 years, 10 months ago (2015-02-04 02:00:32 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 02:00:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/buildbot/+/3adebd8c466918b2e7a8b236d0fbd9484a17...

Powered by Google App Engine
This is Rietveld 408576698