Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 880483002: ChildAccountService: periodically re-fetch parent info; retry on failure (Closed)

Created:
5 years, 11 months ago by Marc Treib
Modified:
5 years, 11 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org, merkulova
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChildAccountService: periodically re-fetch parent info; retry on failure with exponential backoff! BUG=372381, 450828 Committed: https://crrev.com/f528e43789eb29153e5cd242b71fc4db46b32dd3 Cr-Commit-Position: refs/heads/master@{#313065}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -18 lines) Patch
M chrome/browser/supervised_user/child_accounts/child_account_service.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/child_account_service.cc View 6 chunks +39 lines, -18 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Marc Treib
PTAL! https://codereview.chromium.org/880483002/diff/1/chrome/browser/supervised_user/child_accounts/child_account_service.cc File chrome/browser/supervised_user/child_accounts/child_account_service.cc (right): https://codereview.chromium.org/880483002/diff/1/chrome/browser/supervised_user/child_accounts/child_account_service.cc#newcode133 chrome/browser/supervised_user/child_accounts/child_account_service.cc:133: // TODO(treib): Maybe store the last update time ...
5 years, 11 months ago (2015-01-26 13:19:31 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/880483002/diff/1/chrome/browser/supervised_user/child_accounts/child_account_service.cc File chrome/browser/supervised_user/child_accounts/child_account_service.cc (right): https://codereview.chromium.org/880483002/diff/1/chrome/browser/supervised_user/child_accounts/child_account_service.cc#newcode133 chrome/browser/supervised_user/child_accounts/child_account_service.cc:133: // TODO(treib): Maybe store the last update time ...
5 years, 11 months ago (2015-01-26 13:41:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880483002/1
5 years, 11 months ago (2015-01-26 14:00:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 14:46:13 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 14:47:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f528e43789eb29153e5cd242b71fc4db46b32dd3
Cr-Commit-Position: refs/heads/master@{#313065}

Powered by Google App Engine
This is Rietveld 408576698