Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: sky/engine/web/ChromeClientImpl.cpp

Issue 880473003: sky-scrollable should use a reasonable fling curve (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Now with heights Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/public/platform/WebInputEvent.h ('k') | sky/framework/fling-curve.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/web/ChromeClientImpl.cpp
diff --git a/sky/engine/web/ChromeClientImpl.cpp b/sky/engine/web/ChromeClientImpl.cpp
index 40ce3386ca592d7ca05f4e2a6bf319a6b078decf..92a6d2aeb7ce700605adbd4ec014be8e2d77a88d 100644
--- a/sky/engine/web/ChromeClientImpl.cpp
+++ b/sky/engine/web/ChromeClientImpl.cpp
@@ -32,6 +32,7 @@
#include "sky/engine/config.h"
#include "sky/engine/web/ChromeClientImpl.h"
+#include "base/logging.h"
#include "gen/sky/platform/RuntimeEnabledFeatures.h"
#include "sky/engine/bindings/core/v8/ScriptController.h"
#include "sky/engine/core/dom/Document.h"
@@ -203,10 +204,16 @@ inline static String messageLevelAsString(MessageLevel level)
void ChromeClientImpl::addMessageToConsole(LocalFrame* localFrame, MessageSource source, MessageLevel level, const String& message, unsigned lineNumber, const String& sourceID, const String& stackTrace)
{
- if (level == ErrorMessageLevel)
+ if (level == ErrorMessageLevel) {
printf("ERROR: %s \nSOURCE: %s:%u\n", message.utf8().data(), sourceID.utf8().data(), lineNumber);
- else
+ } else {
+#if OS(ANDROID)
+ LOG(INFO) << "CONSOLE: " << messageLevelAsString(level).utf8().data()
esprehn 2015/01/27 01:31:42 Why can't we just LOG() all the time?
abarth-chromium 2015/01/27 01:33:28 It just looks ugly on Linux. There's a bunch of e
+ << ": " << message.utf8().data();
+#else
printf("CONSOLE: %s: %s\n", messageLevelAsString(level).utf8().data(), message.utf8().data());
+#endif
+ }
fflush(stdout);
WebLocalFrameImpl* frame = WebLocalFrameImpl::fromFrame(localFrame);
« no previous file with comments | « sky/engine/public/platform/WebInputEvent.h ('k') | sky/framework/fling-curve.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698