Issue 880473003: sky-scrollable should use a reasonable fling curve

Issue 880473003: sky-scrollable should use a reasonable fling curve (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

sky-scrollable should use a reasonable fling curve This CL uses the aura fling curve to ease flings. Also, I've made Event#timeStamp use consistent units and timebase with the requestAnimationFrame timestamp. Now both are doubles of milliseconds since the epoch. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3045723a7522e08039cc48b73352d856c6d625cc

Patch Set 1 #

Patch Set 2 : Fewer constants #

Patch Set 3 : Directions! #

Patch Set 4 : Now with heights #

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -72 lines)			Patch
M	sky/engine/core/core.gni	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/dom/DOMTimeStamp.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/dom/RequestAnimationFrameCallback.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/dom/ScriptedAnimationController.cpp	View		2 chunks	+3 lines, -10 lines	0 comments	Download
M	sky/engine/core/events/Event.h	View		4 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/engine/core/events/Event.cpp	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	sky/engine/core/events/Event.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/events/GestureEvent.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/events/KeyboardEvent.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/events/PointerEvent.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/core/frame/LocalDOMWindow.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/loader/DocumentLoadTiming.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/loader/DocumentLoadTiming.cpp	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	sky/engine/public/platform/WebInputEvent.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/web/ChromeClientImpl.cpp	View		2 chunks	+9 lines, -2 lines	2 comments	Download
A	sky/framework/fling-curve.sky	View	1 2	1 chunk	+47 lines, -0 lines	0 comments	Download
M	sky/framework/sky-scrollable.sky	View	1 2 3	5 chunks	+19 lines, -26 lines	0 comments	Download
M	sky/viewer/converters/input_event_types.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

esprehn

lgtm, does this still have the scroll up bug? Is your description out of date? ...

5 years, 11 months ago (2015-01-27 01:31:42 UTC) #2

abarth-chromium

https://codereview.chromium.org/880473003/diff/60001/sky/engine/web/ChromeClientImpl.cpp File sky/engine/web/ChromeClientImpl.cpp (right): https://codereview.chromium.org/880473003/diff/60001/sky/engine/web/ChromeClientImpl.cpp#newcode211 sky/engine/web/ChromeClientImpl.cpp:211: LOG(INFO) << "CONSOLE: " << messageLevelAsString(level).utf8().data() On 2015/01/27 at ...

5 years, 11 months ago (2015-01-27 01:33:28 UTC) #3

abarth-chromium

On 2015/01/27 at 01:31:42, esprehn wrote: > lgtm, does this still have the scroll up ...

5 years, 11 months ago (2015-01-27 01:33:50 UTC) #4

abarth-chromium

5 years, 11 months ago (2015-01-27 01:34:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
3045723a7522e08039cc48b73352d856c6d625cc.

Expand Messages | Collapse Messages