src/compiler/ast-graph-builder.cc - Issue 880443004: Fix try-finally for dead AST-branches in TurboFan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 880443004: Fix try-finally for dead AST-branches in TurboFan. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-graph-builder.cc

diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc

index b3c40b3e2e25d7ca7bcd4ff9dcb63508f37078cf..5a87e328ace2b419caf9a6d131eaad61600bb1e2 100644

--- a/src/compiler/ast-graph-builder.cc

+++ b/src/compiler/ast-graph-builder.cc

@@ -1194,7 +1194,6 @@ void AstGraphBuilder::VisitTryCatchStatement(TryCatchStatement* stmt) {

// Create a catch scope that binds the exception.

Node* exception = try_control.GetExceptionNode();

- if (exception == NULL) exception = jsgraph()->NullConstant();

Unique<String> name = MakeUnique(stmt->variable()->name());

const Operator* op = javascript()->CreateCatchContext(name);

Node* context = NewNode(op, exception, GetFunctionClosure());

« no previous file with comments | « src/compiler/ast-graph-builder.h ('k') | src/compiler/control-builders.h » ('j') | no next file with comments »