src/arm/code-stubs-arm.cc - Issue 88043002: Out-of-line constant pool on Arm: Stage 3 - Set Constant Pool Pointer on Function Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/code-stubs-arm.cc

Issue 88043002: Out-of-line constant pool on Arm: Stage 3 - Set Constant Pool Pointer on Function Entry (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Re-upload to fix code-review error. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/code-stubs-arm.cc

diff --git a/src/arm/code-stubs-arm.cc b/src/arm/code-stubs-arm.cc

index bfe6da0ef44ce71a30d7706df141796e7527a050..a91b1d0d4b3569a98978f6462a15e654839e99d5 100644

--- a/src/arm/code-stubs-arm.cc

+++ b/src/arm/code-stubs-arm.cc

@@ -1995,12 +1995,15 @@ void JSEntryStub::GenerateBody(MacroAssembler* masm, bool is_construct) {

Isolate* isolate = masm->isolate();

int marker = is_construct ? StackFrame::ENTRY_CONSTRUCT : StackFrame::ENTRY;

__ mov(r8, Operand(Smi::FromInt(marker)));

+ __ mov(r7, Operand(Smi::FromInt(marker)));

__ mov(r6, Operand(Smi::FromInt(marker)));

__ mov(r5,

Operand(ExternalReference(Isolate::kCEntryFPAddress, isolate)));

__ ldr(r5, MemOperand(r5));

__ mov(ip, Operand(-1)); // Push a bad frame pointer to fail if it is used.

- __ Push(ip, r8, r6, r5);

+ __ stm(db_w, sp, r5.bit() | r6.bit() |

+ (FLAG_enable_ool_constant_pool ? r7.bit() : 0) |

+ r8.bit() | ip.bit());

// Set up frame pointer for the frame to be pushed.

__ add(fp, sp, Operand(-EntryFrameConstants::kCallerFPOffset));

« src/arm/builtins-arm.cc ('K') | « src/arm/builtins-arm.cc ('k') | src/arm/codegen-arm.cc » ('j') | no next file with comments »