Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880423002: add is_app_ready_predicate to testWebView in AndroidAppTest (Closed)

Created:
5 years, 10 months ago by ariblue
Modified:
5 years, 10 months ago
Reviewers:
Zhen Wang, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add is_app_ready_predicate to testWebView in AndroidAppTest BUG=452266 Committed: https://crrev.com/5247f8ac63d461a1b2f96c2b98276ebad42b6f41 Cr-Commit-Position: refs/heads/master@{#313655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/telemetry/telemetry/core/android_app_unittest.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
ariblue
Either this will fix testWebView or cause it to start taking 60 seconds to timeout.
5 years, 10 months ago (2015-01-29 01:05:22 UTC) #2
nednguyen
lgtm
5 years, 10 months ago (2015-01-29 01:55:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880423002/1
5 years, 10 months ago (2015-01-29 01:56:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 03:02:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5247f8ac63d461a1b2f96c2b98276ebad42b6f41 Cr-Commit-Position: refs/heads/master@{#313655}
5 years, 10 months ago (2015-01-29 03:03:43 UTC) #7
Zhen Wang
Do we need to catch TimeoutException? See log: http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28K%20N5%2C%20user%20build%29%28dbg%29/builds/1995/steps/telemetry_unittests/logs/stdio
5 years, 10 months ago (2015-01-29 16:35:32 UTC) #8
nednguyen
On 2015/01/29 16:35:32, Zhen Wang wrote: > Do we need to catch TimeoutException? See log: ...
5 years, 10 months ago (2015-01-29 16:38:48 UTC) #9
ariblue
5 years, 10 months ago (2015-01-29 19:34:35 UTC) #10
Message was sent while issue was closed. 
On 2015/01/29 16:38:48, nednguyen wrote:
> On 2015/01/29 16:35:32, Zhen Wang wrote:
> > Do we need to catch TimeoutException? See log:
> >
>
http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28K%20N5...
> 
> Ah, it looks like that the googlequicksearchbox is not available. @Ari, I
think
> you want to update this to check whether there is android search app on the
> device, if not then skip the test.

I think the googlequicksearchbox:search process has to be running or else we
would have failed earlier. In android_app_backend:
    87    return self.GetProcesses(lambda n: n == process_name).pop()
would have raised a KeyError (trying to pop() on an empty set) instead.

Powered by Google App Engine
This is Rietveld 408576698