net/quic/quic_ack_notifier.cc - Issue 880403006: Further cleanup to QuicAckNotifier and QuicAckNotifierManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_ack_notifier.cc

Issue 880403006: Further cleanup to QuicAckNotifier and QuicAckNotifierManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Remove_unneeded_hash_set_84637544

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_ack_notifier.cc

diff --git a/net/quic/quic_ack_notifier.cc b/net/quic/quic_ack_notifier.cc

index 6236321bf52bb79d0613bcb3a71e96deb774c182..48ee23df1a45bac5c7ce4876489feb930fabfc36 100644

--- a/net/quic/quic_ack_notifier.cc

+++ b/net/quic/quic_ack_notifier.cc

@@ -33,8 +33,7 @@ void QuicAckNotifier::OnSerializedPacket() {

++unacked_packets_;

}

-bool QuicAckNotifier::OnAck(QuicPacketSequenceNumber sequence_number,

- QuicTime::Delta delta_largest_observed) {

+bool QuicAckNotifier::OnAck(QuicTime::Delta delta_largest_observed) {

if (unacked_packets_ <= 0) {

LOG(DFATAL) << "Acked more packets than were tracked."

<< " unacked_packets:" << unacked_packets_;

« no previous file with comments | « net/quic/quic_ack_notifier.h ('k') | net/quic/quic_ack_notifier_manager.cc » ('j') | no next file with comments »