chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc - Issue 880393002: Fix webrtcAudioPrivate API to handle requests from <webview>s.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

Issue 880393002: Fix webrtcAudioPrivate API to handle requests from <webview>s. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for jam's comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc ('K') | « chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc ('k') | chrome/browser/resources/hangout_services/thunk.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

index 2c5df180e33bc3449e1ba89401e81959dec00d94..fa79fc1f7442f5428e717bdd39639c725ac2f06e 100644

--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

@@ -32,7 +32,7 @@

#include "testing/gtest/include/gtest/gtest.h"

using base::JSONWriter;

-using content::RenderViewHost;

+using content::RenderProcessHost;

using content::WebContents;

using media::AudioDeviceNames;

using media::AudioManager;

@@ -49,7 +49,7 @@ class AudioWaitingExtensionTest : public ExtensionApiTest {

// or more AudioOutputController objects for our tab.

bool audio_playing = false;

for (size_t remaining_tries = 50; remaining_tries > 0; --remaining_tries) {

- tab->GetRenderViewHost()->GetAudioOutputControllers(

+ tab->GetRenderProcessHost()->GetAudioOutputControllers(

base::Bind(OnAudioControllers, &audio_playing));

base::MessageLoop::current()->RunUntilIdle();

if (audio_playing)

@@ -65,7 +65,7 @@ class AudioWaitingExtensionTest : public ExtensionApiTest {

// Used by the test above to wait until audio is playing.

static void OnAudioControllers(

bool* audio_playing,

- const RenderViewHost::AudioOutputControllerList& list) {

+ const RenderProcessHost::AudioOutputControllerList& list) {

if (!list.empty())

*audio_playing = true;

}