Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 880373004: Implement of privet/v3/auth after pairing. (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@patches
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement of privet/v3/auth after pairing. After successfull pairing session will call auth API to get access token. BUG=449864 Committed: https://crrev.com/612b593d1f64d82c27b602a73fa2e3dd1c6355e7 Cr-Commit-Position: refs/heads/master@{#313901}

Patch Set 1 #

Patch Set 2 : Wed Jan 28 15:55:58 PST 2015 #

Patch Set 3 : Fri Jan 30 02:09:03 PST 2015 #

Patch Set 4 : Fri Jan 30 02:24:45 PST 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -2 lines) Patch
M chrome/browser/local_discovery/privetv3_session.h View 4 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/privetv3_session.cc View 1 2 3 3 chunks +50 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/privetv3_session_unittest.cc View 1 2 3 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-01-28 23:56:38 UTC) #2
Aleksey Shlyapnikov
lgtm
5 years, 10 months ago (2015-01-29 01:04:07 UTC) #3
Aleksey Shlyapnikov
lgtm
5 years, 10 months ago (2015-01-29 01:04:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880373004/60001
5 years, 10 months ago (2015-01-30 10:11:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/3347)
5 years, 10 months ago (2015-01-30 10:21:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880373004/80001
5 years, 10 months ago (2015-01-30 10:26:22 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-01-30 12:12:26 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 12:13:40 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/612b593d1f64d82c27b602a73fa2e3dd1c6355e7
Cr-Commit-Position: refs/heads/master@{#313901}

Powered by Google App Engine
This is Rietveld 408576698