Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 880373003: Add cr_cronet.py stack command to symbolize native stack from adb logcat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/cr_cronet.py
diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py
index bdc7312aeaf70251205131d145105d87e041321a..7d2c269bd092a54523b726c5339f7e4aa1f1465a 100755
--- a/components/cronet/tools/cr_cronet.py
+++ b/components/cronet/tools/cr_cronet.py
@@ -40,6 +40,11 @@ def debug(extra_options):
' '.join(extra_options))
+def stack(out_dir):
+ return run ('adb logcat -d | third_party/android_tools/ndk/ndk-stack ' + \
+ '-sym ' + out_dir + '/lib')
+
+
def main():
parser = argparse.ArgumentParser()
parser.add_argument('command',
@@ -50,6 +55,7 @@ def main():
'proguard',
'test',
'build-test',
+ 'stack',
'debug',
'build-debug'])
parser.add_argument('-r', '--release', action='store_true',
@@ -83,6 +89,8 @@ def main():
if (options.command=='build-test'):
return build(out_dir) or install(release_arg) or \
test(release_arg, extra_options)
+ if (options.command=='stack'):
+ return stack(out_dir)
if (options.command=='debug'):
return install(release_arg) or debug(extra_options)
if (options.command=='build-debug'):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698