[Autofill] Log the number of autofill profiles available at form submission

components/autofill/core/browser/autofill_metrics_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
@@ skipping 344 matching lines @@
       "Autofill.Quality.PredictedType.ByFieldType",
       GetFieldTypeGroupMetric(PHONE_HOME_WHOLE_NUMBER,
                               AutofillMetrics::TYPE_MATCH),
       1);
   // Mismatch:
   histogram_tester.ExpectBucketCount("Autofill.Quality.PredictedType",
                                      AutofillMetrics::TYPE_MISMATCH, 1);
   histogram_tester.ExpectBucketCount(
       "Autofill.Quality.PredictedType.ByFieldType",
       GetFieldTypeGroupMetric(NAME_FULL, AutofillMetrics::TYPE_MISMATCH), 1);
+
+  // An autofillable form was submitted, and number of stored profiles is
+  // logged.
+  histogram_tester.ExpectBucketCount(
+      "Autofill.StoredProfileCountAtAutofillableFormSubmission", 2, 1);

[Ilya Sherman, 2015/01/30 22:11:44]

This isn't a quality metric.  Please write a separate TEST_F test case for this
histogram.

[Mathieu, 2015/01/31 18:25:51]

Done. Thanks, cleaner now.

 }
 
 // Test that we behave sanely when the cached form differs from the submitted
 // one.
 TEST_F(AutofillMetricsTest, SaneMetricsWithCacheMismatch) {
   // Set up our form data.
   FormData form;
   form.name = ASCIIToUTF16("TestForm");
   form.origin = GURL("http://example.com/form.html");
   form.action = GURL("http://example.com/submit.html");
@@ skipping 123 matching lines @@
       "Autofill.Quality.PredictedType.ByFieldType",
       GetFieldTypeGroupMetric(ADDRESS_HOME_CITY,
                               AutofillMetrics::TYPE_MISMATCH),
       1);
   histogram_tester.ExpectBucketCount(
       "Autofill.Quality.PredictedType.ByFieldType",
       GetFieldTypeGroupMetric(EMAIL_ADDRESS, AutofillMetrics::TYPE_MISMATCH),
       1);
 }
 
+// Verify that when submitting a non-autofillable form, the stored profile
+// metric is not logged.
+TEST_F(AutofillMetricsTest, StoredProfileCountNonAutofillableFormSubmission) {
+  // Construct a non-fillable form.
+  FormData form;
+  form.name = ASCIIToUTF16("TestForm");
+  form.origin = GURL("http://example.com/form.html");
+  form.action = GURL("http://example.com/submit.html");
+
+  // Two fields is not enough to make it an autofillable form.
+  FormFieldData field;
+  test::CreateTestFormField("Name", "name", "", "text", &field);
+  form.fields.push_back(field);
+  test::CreateTestFormField("Email", "email", "", "text", &field);
+  form.fields.push_back(field);
+
+  // Simulate form submission.
+  base::HistogramTester histogram_tester;
+  autofill_manager_->FormSubmitted(form, TimeTicks::Now());
+
+  // A non-autofillable form was submitted, and number of stored profiles is NOT
+  // logged.
+  histogram_tester.ExpectTotalCount(
+      "Autofill.StoredProfileCountAtAutofillableFormSubmission", 0);
+}
+
 // Verify that we correctly log metrics regarding developer engagement.
 TEST_F(AutofillMetricsTest, DeveloperEngagement) {
   // Start with a non-fillable form.
   FormData form;
   form.name = ASCIIToUTF16("TestForm");
   form.origin = GURL("http://example.com/form.html");
   form.action = GURL("http://example.com/submit.html");
 
   FormFieldData field;
   test::CreateTestFormField("Name", "name", "", "text", &field);
@@ skipping 575 matching lines @@
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithAutofill", 0);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithoutAutofill", 0);
 
     autofill_manager_->Reset();
   }
 }
 
 }  // namespace autofill