[Autofill] Log the number of autofill profiles available at form submission

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/test/histogram_tester.h"
 #include "base/time/time.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
 #include "components/autofill/core/browser/test_autofill_client.h"
 #include "components/autofill/core/browser/test_autofill_driver.h"
@@ skipping 649 matching lines @@
     FillAutofillFormData(input_query_id, input_form, input_field, unique_id);
   }
 
   int MakeFrontendID(const SuggestionBackendID& cc_sid,
                  const SuggestionBackendID& profile_sid) const {
     return autofill_manager_->MakeFrontendID(cc_sid, profile_sid);
   }
 
  protected:
   base::MessageLoop message_loop_;
+  base::HistogramTester histogram_tester_;
   TestAutofillClient autofill_client_;
   scoped_ptr<MockAutofillDriver> autofill_driver_;
   scoped_ptr<TestAutofillManager> autofill_manager_;
   scoped_ptr<TestAutofillExternalDelegate> external_delegate_;
   TestPersonalDataManager personal_data_;
 };
 
 class TestFormStructure : public FormStructure {
  public:
   explicit TestFormStructure(const FormData& form)
@@ skipping 1523 matching lines @@
   FormData response_data;
   FillAutofillFormDataAndSaveResults(kDefaultPageID, form, form.fields[0],
       MakeFrontendID(empty, guid), &response_page_id, &response_data);
   ExpectFilledAddressFormElvis(
       response_page_id, response_data, kDefaultPageID, false);
 
   // Simulate form submission. We should call into the PDM to try to save the
   // filled data.
   EXPECT_CALL(personal_data_, SaveImportedProfile(::testing::_)).Times(1);
   FormSubmitted(response_data);
+
+  histogram_tester_.ExpectUniqueSample(
+      "Autofill.StoredProfileCountAtAutofillableFormSubmission", 3, 1);

[Ilya Sherman, 2015/01/29 20:34:52]

Please move this test to the autofill_metrics_unittest file, and please write
minimal tests to cover the possible cases.  At the least, I would suggest having
one test for when this histogram is emitted to, and one test verifying that it
is *not* emitted to when a non-autofillable form is submitted.

[Mathieu, 2015/01/30 15:22:41]

Done.

 }
 
 // Test that when Autocomplete is enabled and Autofill is disabled,
 // form submissions are still received by AutocompleteHistoryManager.
 TEST_F(AutofillManagerTest, FormSubmittedAutocompleteEnabled) {
   TestAutofillClient client;
   autofill_manager_.reset(
       new TestAutofillManager(autofill_driver_.get(), &client, NULL));
   autofill_manager_->set_autofill_enabled(false);
   scoped_ptr<MockAutocompleteHistoryManager> autocomplete_history_manager;
@@ skipping 683 matching lines @@
   // results. This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   external_delegate_->CheckSuggestions(
       kDefaultPageID,
       Suggestion("Visa - 3456", "04/12", kVisaCard,
                  autofill_manager_->GetPackedCreditCardID(4)));
 }
 
 }  // namespace autofill