content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 88033002: Add RGB565 Texture readback support in gl_helper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 88033002: Add RGB565 Texture readback support in gl_helper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes done as per review comments (WIP: gl_helper_unittests) Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 43b00861abb053e1e4880a74d6b8cc09c54956dd..1ee5d45224c9286425fe642f02da303b3454b7a1 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -1134,7 +1134,12 @@ BackingStore* RenderWidgetHostViewMac::AllocBackingStore(

void RenderWidgetHostViewMac::CopyFromCompositingSurface(

const gfx::Rect& src_subrect,

const gfx::Size& dst_size,

- const base::Callback<void(bool, const SkBitmap&)>& callback) {

+ const base::Callback<void(bool, const SkBitmap&)>& callback,

+ bool readback_config_rgb565) {

+ if (readback_config_rgb565) {

+ NOTIMPLEMENTED();

+ callback.Run(false, SkBitmap());

+ }

base::ScopedClosureRunner scoped_callback_runner(

base::Bind(callback, false, SkBitmap()));

float scale = ScaleFactor(cocoa_view_);