Add additional layout tests for MediaKeySession.keyStatuses

Add additional layout tests for MediaKeySession.keyStatuses

Adds tests for multiple sessions and multiple updates to the same
session. Also updates existing test to do more verification and
check forEach() now that it is implemented.

BUG=432671
TEST=new tests pass

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189351

[jrummell, 2015-01-28 19:25:44]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, sandersd@chromium.org

[jrummell, 2015-01-28 19:25:44]

PTAL.

[sandersd (OOO until July 31), 2015-01-30 20:40:00]

https://codereview.chromium.org/880313003/diff/1/LayoutTests/media/encrypted-...
File LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html (right):

https://codereview.chromium.org/880313003/diff/1/LayoutTests/media/encrypted-...
LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html:48: for (var
entry of mediaKeySession.keyStatuses) {
This could be made into a helper function that, given keyStatuses or a list of
keys, does the conversion to string and then sorts the resulting list. Then you
can just use assery_array_equals on the resulting list.

https://codereview.chromium.org/880313003/diff/1/LayoutTests/media/encrypted-...
File LayoutTests/media/encrypted-media/encrypted-media-utils.js (right):

https://codereview.chromium.org/880313003/diff/1/LayoutTests/media/encrypted-...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:138: function
verifyKeyStatuses(keyStatuses, expectedKeys, otherKeys)
Consider taking the expected/other keys parameters as an object, ie:

    verifyKeyStatuses(keyStatuses, {expectedKeys: [], unexpectedKeys: []});

so that it's clearer from the call site what is being done.

[jrummell, 2015-01-30 22:33:56]

JavaScript updated.

https://codereview.chromium.org/880313003/diff/1/LayoutTests/media/encrypted-...
File LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html (right):

https://codereview.chromium.org/880313003/diff/1/LayoutTests/media/encrypted-...
LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html:48: for (var
entry of mediaKeySession.keyStatuses) {
On 2015/01/30 20:40:00, sandersd wrote:
> This could be made into a helper function that, given keyStatuses or a list of
> keys, does the conversion to string and then sorts the resulting list. Then
you
> can just use assery_array_equals on the resulting list.

Done.

https://codereview.chromium.org/880313003/diff/1/LayoutTests/media/encrypted-...
File LayoutTests/media/encrypted-media/encrypted-media-utils.js (right):

https://codereview.chromium.org/880313003/diff/1/LayoutTests/media/encrypted-...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:138: function
verifyKeyStatuses(keyStatuses, expectedKeys, otherKeys)
On 2015/01/30 20:40:00, sandersd wrote:
> Consider taking the expected/other keys parameters as an object, ie:
> 
>     verifyKeyStatuses(keyStatuses, {expectedKeys: [], unexpectedKeys: []});
> 
> so that it's clearer from the call site what is being done.

Done.

[sandersd (OOO until July 31), 2015-01-30 22:51:38]

https://codereview.chromium.org/880313003/diff/20001/LayoutTests/media/encryp...
File LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html (right):

https://codereview.chromium.org/880313003/diff/20001/LayoutTests/media/encryp...
LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html:69:
compare_array(result,
If we are comparing both the key and the value, then just make result an object
and use assert_object_equals(). (Actually, we can use that as a trick to get set
comparison, just use an object mapping keys to 'true'.)

https://codereview.chromium.org/880313003/diff/20001/LayoutTests/media/encryp...
File LayoutTests/media/encrypted-media/encrypted-media-utils.js (right):

https://codereview.chromium.org/880313003/diff/20001/LayoutTests/media/encryp...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:138: // 'usable'.
Best to provide an example call.

https://codereview.chromium.org/880313003/diff/20001/LayoutTests/media/encryp...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:142: 'Incorrect usage
of verifyKeyStatuses()');
Alternatively, you can use the more common notation:

    var expected = keys.expected || [];

Then you can skip providing empty expectations. (This would have to be
documented though, as the alternative behavior of not checking if they are not
passed is also reasonable.)

[jrummell, 2015-01-30 23:18:26]

Updated.

https://codereview.chromium.org/880313003/diff/20001/LayoutTests/media/encryp...
File LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html (right):

https://codereview.chromium.org/880313003/diff/20001/LayoutTests/media/encryp...
LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html:69:
compare_array(result,
On 2015/01/30 22:51:38, sandersd wrote:
> If we are comparing both the key and the value, then just make result an
object
> and use assert_object_equals(). (Actually, we can use that as a trick to get
set
> comparison, just use an object mapping keys to 'true'.)

assert_object_equals() works.

https://codereview.chromium.org/880313003/diff/20001/LayoutTests/media/encryp...
File LayoutTests/media/encrypted-media/encrypted-media-utils.js (right):

https://codereview.chromium.org/880313003/diff/20001/LayoutTests/media/encryp...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:138: // 'usable'.
On 2015/01/30 22:51:38, sandersd wrote:
> Best to provide an example call.

Done.

https://codereview.chromium.org/880313003/diff/20001/LayoutTests/media/encryp...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:142: 'Incorrect usage
of verifyKeyStatuses()');
On 2015/01/30 22:51:38, sandersd wrote:
> Alternatively, you can use the more common notation:
> 
>     var expected = keys.expected || [];
> 
> Then you can skip providing empty expectations. (This would have to be
> documented though, as the alternative behavior of not checking if they are not
> passed is also reasonable.)

Done. I removed unexpected: [], but left in empty expected so it's obvious that
no keys are expected.

[sandersd (OOO until July 31), 2015-01-30 23:22:46]

lgtm

Basically just a nit left.

lgtm.

https://codereview.chromium.org/880313003/diff/40001/LayoutTests/media/encryp...
File LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html (right):

https://codereview.chromium.org/880313003/diff/40001/LayoutTests/media/encryp...
LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html:49:
result.push({ key: arrayBufferAsString(entry[0]), value: entry[1] });
I think 'result[arrayBufferAsString(entry[0])] = entry[1]' makes more sense.

[jrummell, 2015-02-02 18:16:59]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2015-02-02 18:17:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880313003/40001

[commit-bot: I haz the power, 2015-02-02 18:24:18]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189351