chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc - Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cros Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.cc ('k') | chrome/browser/ui/webui/chromeos/login/oobe_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

diff --git a/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc b/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

index dcf70776ce99c36e4caff2212549c2006d54b458..2cfe4cbe66f265d2a9bbdbe979e5452cd79db040 100644

--- a/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

+++ b/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

@@ -6,6 +6,7 @@

#include "ash/shell.h"

#include "base/command_line.h"

+#include "chrome/browser/browser_process.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/webui/chromeos/first_run/first_run_handler.h"

#include "chrome/common/url_constants.h"

@@ -85,7 +86,8 @@ content::WebUIDataSource* CreateDataSource() {

source->SetDefaultResource(IDR_FIRST_RUN_HTML);

source->AddResourcePath(kFirstRunJSPath, IDR_FIRST_RUN_JS);

base::DictionaryValue localized_strings;

- webui::SetFontAndTextDirection(&localized_strings);

+ const std::string& app_locale = g_browser_process->GetApplicationLocale();

+ webui::SetLoadTimeDataDefaults(app_locale, &localized_strings);

SetLocalizedStrings(&localized_strings);

source->AddLocalizedStrings(localized_strings);

return source;