chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc - Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc

Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/first_run/first_run.html ('K') | « chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc

diff --git a/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc b/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc

index 7f32951c3801ac10f46e70ae1b54d2371a6fbd14..f21241b2d5967123386c3f59132fa0c33b662b9a 100644

--- a/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc

+++ b/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc

@@ -16,6 +16,7 @@

#include "base/message_loop/message_loop.h"

#include "base/strings/string_piece.h"

#include "base/values.h"

+#include "chrome/browser/browser_process.h"

#include "chrome/browser/chromeos/sim_dialog_delegate.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/common/url_constants.h"

@@ -322,7 +323,8 @@ void SimUnlockUIHTMLSource::StartDataRequest(

strings.SetString("oldPin", l10n_util::GetStringUTF16(

IDS_OPTIONS_SETTINGS_INTERNET_CELLULAR_CHANGE_PIN_OLD_PIN));

- webui::SetFontAndTextDirection(&strings);

+ const std::string& app_locale = g_browser_process->GetApplicationLocale();

+ webui::SetLoadTimeDataDefaults(&strings);

dmazzoni 2015/01/28 17:20:54 Did you mean to pass app_locale? Please check thr

Dan Beam 2015/01/28 17:48:27 Done. try bot will catch any other stupid mistake

static const base::StringPiece html(

ResourceBundle::GetSharedInstance().GetRawDataResource(