Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 880303002: Eliminate last vestigages of the command system design. (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
mtomasz, Ben Kwa
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate last vestiges of the command system design. Update ImportController to push all updates to a new 'CommandWidget' class. Add more test coverage. BUG=420680 TEST=browser_test: FileManagerJsTest.* Committed: https://crrev.com/d4f3217ab2f151f6e2a6be52fe947672813d3c58 Cr-Commit-Position: refs/heads/master@{#313622}

Patch Set 1 #

Patch Set 2 : Merge w/ master. #

Total comments: 1

Patch Set 3 : Respond to review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -63 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +1 line, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 2 7 chunks +66 lines, -43 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller_unittest.js View 1 10 chunks +73 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Steve McKay
5 years, 10 months ago (2015-01-28 16:36:48 UTC) #2
Steve McKay
Reviews: Fukino-san || Tomasz...which ever is first.
5 years, 10 months ago (2015-01-28 17:42:39 UTC) #4
Ben Kwa
lgtm
5 years, 10 months ago (2015-01-28 18:16:01 UTC) #5
mtomasz
On 2015/01/28 18:16:01, Ben Kwa wrote: > lgtm nit: Please keep the CL description: Short ...
5 years, 10 months ago (2015-01-28 18:35:16 UTC) #6
Steve McKay
On 2015/01/28 18:35:16, mtomasz wrote: > On 2015/01/28 18:16:01, Ben Kwa wrote: > > lgtm ...
5 years, 10 months ago (2015-01-28 18:41:14 UTC) #7
Steve McKay
Merge w/ master.
5 years, 10 months ago (2015-01-28 20:46:13 UTC) #9
mtomasz
lgtm https://codereview.chromium.org/880303002/diff/20001/ui/file_manager/file_manager/foreground/js/import_controller.js File ui/file_manager/file_manager/foreground/js/import_controller.js (right): https://codereview.chromium.org/880303002/diff/20001/ui/file_manager/file_manager/foreground/js/import_controller.js#newcode470 ui/file_manager/file_manager/foreground/js/import_controller.js:470: nit: remove \n
5 years, 10 months ago (2015-01-28 22:54:03 UTC) #10
Steve McKay
Respond to review comments.
5 years, 10 months ago (2015-01-28 23:14:50 UTC) #11
Steve McKay
Dones. Thanks.
5 years, 10 months ago (2015-01-28 23:15:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880303002/40001
5 years, 10 months ago (2015-01-28 23:16:10 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-28 23:53:15 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 23:54:20 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d4f3217ab2f151f6e2a6be52fe947672813d3c58
Cr-Commit-Position: refs/heads/master@{#313622}

Powered by Google App Engine
This is Rietveld 408576698