Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880283003: Absence of keyboard layout is fatal. (Closed)

Created:
5 years, 10 months ago by kpschoedel
Modified:
5 years, 10 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Absence of keyboard layout is fatal. R=spang Committed: https://crrev.com/d2f31bf36144d8e1abb9a84f5eb2788ff3d66789 Cr-Commit-Position: refs/heads/master@{#313596}

Patch Set 1 #

Total comments: 2

Patch Set 2 : failure to set is fatal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
kpschoedel
5 years, 10 months ago (2015-01-28 19:40:01 UTC) #1
spang
https://codereview.chromium.org/880283003/diff/1/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc File ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc (right): https://codereview.chromium.org/880283003/diff/1/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc#newcode733 ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc:733: LOG(ERROR) << "Keymap file failed to load: " << ...
5 years, 10 months ago (2015-01-28 20:00:10 UTC) #2
kpschoedel
https://codereview.chromium.org/880283003/diff/1/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc File ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc (right): https://codereview.chromium.org/880283003/diff/1/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc#newcode733 ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc:733: LOG(ERROR) << "Keymap file failed to load: " << ...
5 years, 10 months ago (2015-01-28 21:22:19 UTC) #3
spang
lgtm
5 years, 10 months ago (2015-01-28 21:34:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880283003/20001
5 years, 10 months ago (2015-01-28 22:13:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 22:44:55 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 22:46:06 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d2f31bf36144d8e1abb9a84f5eb2788ff3d66789
Cr-Commit-Position: refs/heads/master@{#313596}

Powered by Google App Engine
This is Rietveld 408576698