Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 880283002: Add a script to fetch the latest SKPs. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a script to fetch the latest SKPs. I keep forgetting how best to do this. NOTRY=true NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/674cd7e05c79ee60216c4d0fd53c2c0e162a7887

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments etc #

Patch Set 3 : works from anywhere #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A bin/fetch-skps View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
mtklein
5 years, 10 months ago (2015-01-28 15:31:25 UTC) #2
hal.canary
https://codereview.chromium.org/880283002/diff/1/bin/fetch-skps File bin/fetch-skps (right): https://codereview.chromium.org/880283002/diff/1/bin/fetch-skps#newcode3 bin/fetch-skps:3: gsutil -m cp -r gs://chromium-skia-gm/playback_`cat SKP_VERSION`/skps . #!/bin/sh version="$(cat ...
5 years, 10 months ago (2015-01-28 15:37:02 UTC) #3
mtklein
> version="$(cat "$(cd "$(dirname "$0")"; pwd)/../SKP_VERSION")" > gsutil -m cp -r gs://chromium-skia-gm/playback_${version}/skps . ptal
5 years, 10 months ago (2015-01-28 15:45:58 UTC) #4
hal.canary
On 2015/01/28 15:45:58, mtklein wrote: > > version="$(cat "$(cd "$(dirname "$0")"; pwd)/../SKP_VERSION")" > > gsutil ...
5 years, 10 months ago (2015-01-28 15:48:44 UTC) #5
mtklein
On 2015/01/28 15:48:44, Hal Canary wrote: > On 2015/01/28 15:45:58, mtklein wrote: > > > ...
5 years, 10 months ago (2015-01-28 15:49:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880283002/40001
5 years, 10 months ago (2015-01-28 15:49:33 UTC) #8
hal.canary
On 2015/01/28 15:49:33, mtklein wrote: > On 2015/01/28 15:48:44, Hal Canary wrote: > > If ...
5 years, 10 months ago (2015-01-28 15:51:35 UTC) #9
mtklein
> The set of people who put spaces in file names and the set of ...
5 years, 10 months ago (2015-01-28 16:04:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880283002/40001
5 years, 10 months ago (2015-01-28 17:39:04 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 17:39:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/674cd7e05c79ee60216c4d0fd53c2c0e162a7887

Powered by Google App Engine
This is Rietveld 408576698