Adding the AccessTokenFetcher and Environment class to the app remoting test

remoting/test/mock_access_token_fetcher.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_TEST_MOCK_ACCESS_TOKEN_FETCHER_H_
+#define REMOTING_TEST_MOCK_ACCESS_TOKEN_FETCHER_H_
+
+#include "remoting/test/access_token_fetcher.h"
+
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace remoting {
+namespace test {
+
+// Used for testing classes which rely on the AccessTokenFetcher and want to
+// simulate success and failure scenarios without using the actual class and
+// network connection.
+class MockAccessTokenFetcher : public AccessTokenFetcher {
+ public:
+  MockAccessTokenFetcher();
+  ~MockAccessTokenFetcher() override;
+
+  MOCK_METHOD2(GetAccessTokenFromAuthCode,
+               void(const std::string& auth_code,
+                    const AccessTokenCallback& callback));
+
+  MOCK_METHOD2(GetAccessTokenFromRefreshToken,
+               void(const std::string& refresh_token,
+                    const AccessTokenCallback& callback));
+
+  // Stores a fake object and wires up the mock methods to call through to the
+  // appropriate method on the fake object.
+  void SetFakeAccessTokenFetcher(scoped_ptr<AccessTokenFetcher> fake);

[Wez, 2015/02/23 20:17:15]

This accepts any AccessTokenFetcher, so you shouldn't describe it as "fake".
e.g. rename this SetRealAccessTokenFetcher() or SetDelegateAccessTokenFetcher().
You can still mention in the comment that this is typically used to pass a fake
to which the mock should delegate, so that the calling test can mock it just to
catch calls.

[joedow, 2015/02/24 02:01:24]

Done.

+
+ private:
+  // Delegates the default actions of the methods to a fake object.
+  // This must be called *before* the custom ON_CALL() statements.

[Wez, 2015/02/23 20:17:15]

This comment doesn't make sense - the method is private so no-one can call it at
all.

Move this functionality into SetFakeAccessTokenFetcher()?

[joedow, 2015/02/24 02:01:24]

Done.

+  void DelegateMethodCallsToFake();
+
+  scoped_ptr<AccessTokenFetcher> fake_;
+
+  DISALLOW_COPY_AND_ASSIGN(MockAccessTokenFetcher);
+};
+
+}  // namespace test
+}  // namespace remoting
+
+#endif  // REMOTING_TEST_MOCK_ACCESS_TOKEN_FETCHER_H_