Adding the AccessTokenFetcher and Environment class to the app remoting test

remoting/test/refresh_token_store.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_TEST_REFRESH_TOKEN_STORE_H_
+#define REMOTING_TEST_REFRESH_TOKEN_STORE_H_
+
+#include <string>
+
+#include "base/memory/scoped_ptr.h"
+
+namespace remoting {
+namespace test {
+
+// Used to allow classes which use this functionality to remove the file system
+// dependency for testing.

[Wez, 2015/02/19 22:00:24]

What functionality?

[joedow, 2015/02/20 02:58:36]

Done.

+class RefreshTokenStoreInterface {

[Wez, 2015/02/19 22:00:24]

RefreshTokenStore - Chromium style has the interface with a "plain" name and
implementations with longer names, e.g. RefreshTokenStoreOnDisk, etc.

[joedow, 2015/02/20 02:58:36]

Done.

+ public:
+  RefreshTokenStoreInterface() {}
+  virtual ~RefreshTokenStoreInterface() {}
+
+  virtual std::string ReadRefreshTokenFromDisk(

[Wez, 2015/02/19 22:00:24]

This name assumes an on-disk implementation, but this is an interface so I think
you want just Get/SetRefreshToken or Store/FetchRefreshToken.

[joedow, 2015/02/20 02:58:36]

Done.

+      const std::string& user_name) = 0;
+  virtual bool WriteRefreshTokenToDisk(
+      const std::string& user_name,
+      const std::string& refresh_token) = 0;
+};
+
+scoped_ptr<RefreshTokenStoreInterface> GetRefreshTokenStoreForDisk();

[Wez, 2015/02/19 22:00:24]

Suggest making this a static OnDisk() method in RefreshTokenStore, i.e.
RefreshTokenStore::OnDisk()

[joedow, 2015/02/20 02:58:36]

Done.

+
+}  // namespace test
+}  // namespace remoting
+
+#endif  // REMOTING_TEST_REFRESH_TOKEN_STORE_H_