Adding the AccessTokenFetcher and Environment class to the app remoting test

remoting/test/access_token_fetcher.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_TEST_ACCESS_TOKEN_FETCHER_H_
+#define REMOTING_TEST_ACCESS_TOKEN_FETCHER_H_
+
+#include "base/callback.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "google_apis/gaia/gaia_oauth_client.h"
+
+namespace remoting {
+namespace test {
+
+typedef base::Callback<void(
+    const std::string& access_token,
+    const std::string& refresh_token)> AccessTokenCallback;
+
+// Retrieves an access token from either an authorization code or a refresh
+// token.  A new callback is supplied by the client for each gaia network call
+// which will return a valid token on success or an empty token on failure.

[Wez, 2015/02/19 22:00:23]

I think you mean "for each request to GAIA".

Why are you documenting the contents of the token field to the callback here,
rather than on the definition of the callback type, or the function to which the
callback is supplied?

[joedow, 2015/02/20 02:58:35]

Done.

+// Destroying the AccessTokenFetcher while a request is outstanding will cancel
+// the request. It is safe to delete the fetcher from within a completion
+// callback.  Must be used from a thread running an IO message loop.
+// The public methods are virtual to allow for mocking and fakes.
+class AccessTokenFetcher : public gaia::GaiaOAuthClient::Delegate {
+ public:
+  AccessTokenFetcher();
+  ~AccessTokenFetcher() override;
+
+  // Retrieve an access token from a one time use authorization code.
+  virtual void GetAccessTokenFromAuthCode(const std::string& auth_code,
+                                          const AccessTokenCallback& callback);
+
+  // Retrieve an access token from a refresh token.
+  virtual void GetAccessTokenFromRefreshToken(
+      const std::string& refresh_token,
+      const AccessTokenCallback& callback);
+
+ private:
+  // gaia::GaiaOAuthClient::Delegate Interface.
+  void OnGetTokensResponse(const std::string& refresh_token,
+                           const std::string& access_token,
+                           int expires_in_seconds) override;
+  void OnRefreshTokenResponse(const std::string& access_token,
+                              int expires_in_seconds) override;
+  void OnGetUserEmailResponse(const std::string& user_email) override;
+  void OnGetUserIdResponse(const std::string& user_id) override;
+  void OnGetUserInfoResponse(
+      scoped_ptr<base::DictionaryValue> user_info) override;
+  void OnGetTokenInfoResponse(
+      scoped_ptr<base::DictionaryValue> token_info) override;
+  void OnOAuthError() override;
+  void OnNetworkError(int response_code) override;
+
+  // Updates |auth_client_| with a new GaiaOAuthClient instance.
+  void CreateNewGaiaOAuthClientInstance();
+
+  // Validates the retrieved access token.
+  void ValidateAccessToken();
+
+  // Caller-supplied callback used to return valid tokens on success or empty
+  // tokens on failure.
+  AccessTokenCallback access_token_callback_;
+
+  // Retrieved based on the |refresh_token_|.
+  std::string access_token_;
+
+  // Supplied by the caller or retrieved from a caller-supplied auth token.
+  std::string refresh_token_;
+
+  // Holds the client id, secret, and redirect url used to make
+  // the Gaia service request.
+  gaia::OAuthClientInfo oauth_client_info_;
+
+  // Used to make token requests to GAIA.  Uses a request_context_getter
+  // to make those requests on the current thread's task runner.

[Wez, 2015/02/19 22:00:23]

Do you need the second line? Is that property not part of the GaiaOAuthClient's
interface?

There is no request_context_getter member - do you mean URLRequestContextGetter,
the type?

[joedow, 2015/02/20 02:58:35]

I think that line was more pertinent in a previous iteration, I've removed it.

+  scoped_ptr<gaia::GaiaOAuthClient> auth_client_;
+
+  DISALLOW_COPY_AND_ASSIGN(AccessTokenFetcher);
+};
+
+}  // namespace test
+}  // namespace remoting
+
+#endif  // REMOTING_TEST_ACCESS_TOKEN_FETCHER_H_