Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 880263005: Initialize variations seed fetching via OnAppEnterForeground. (Closed)

Created:
5 years, 10 months ago by Alexei Svitkine (slow)
Modified:
5 years, 10 months ago
Reviewers:
rkaplow, jwd, sky
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize variations seed fetching via OnAppEnterForeground. On Android, instead of calling StartRepeatedVariationsSeedFetch() in chrome_browser_main.cc, this changes the code to instead have that be called by the first call to OnAppEnterForeground(). This will allow (in a future change) to have the caller of OnAppEnterForeground() to first set the restrict mode param, before fetching gets initialized. (Otherwise, fetching was being initialized too early before the param could be set.) BUG=452605 Committed: https://crrev.com/391ece3aa22ebad761a63628dd10dfdef9028f7b Cr-Commit-Position: refs/heads/master@{#313746}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Alexei Svitkine (slow)
5 years, 10 months ago (2015-01-28 20:38:21 UTC) #3
jwd
lgtm
5 years, 10 months ago (2015-01-29 15:37:25 UTC) #4
rkaplow
lgtm
5 years, 10 months ago (2015-01-29 15:46:43 UTC) #5
rkaplow
lgtm
5 years, 10 months ago (2015-01-29 15:46:44 UTC) #6
Alexei Svitkine (slow)
+sky for chrome/browser owners
5 years, 10 months ago (2015-01-29 15:49:10 UTC) #8
sky
LGTM
5 years, 10 months ago (2015-01-29 17:42:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880263005/20001
5 years, 10 months ago (2015-01-29 18:02:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-01-29 18:44:00 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 18:44:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/391ece3aa22ebad761a63628dd10dfdef9028f7b
Cr-Commit-Position: refs/heads/master@{#313746}

Powered by Google App Engine
This is Rietveld 408576698