Issue 88026: Added ForceSet on objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88026: Added ForceSet on objects (Closed)

Created:
11 years, 8 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Added method to forcefully set a local property, ignoring ReadOnly, accessors or interceptors.

Patch Set 1 #

Patch Set 2 : Added docs for ForceSet #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+232 lines, -9 lines)			Patch
M	include/v8.h	View	1	1 chunk	+10 lines, -0 lines	1 comment	Download
M	src/api.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/handles.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/handles.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/objects.cc	View		2 chunks	+15 lines, -9 lines	1 comment	Download
M	src/runtime.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+53 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+115 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 8 months ago (2009-04-21 13:24:16 UTC) #2

LGTM

http://codereview.chromium.org/88026/diff/1001/1002
File include/v8.h (right):

http://codereview.chromium.org/88026/diff/1001/1002#newcode1049
Line 1049: // Sets a local property on this object, bypassing interceptors and
For now this only forces the set for string keys, right?  We should probably
document here that the set is not forced if the key can be converted to an array
index.

http://codereview.chromium.org/88026/diff/1001/1006
File src/objects.cc (right):

http://codereview.chromium.org/88026/diff/1001/1006#newcode1823
Line 1823: case CALLBACKS: case INTERCEPTOR:
Two lines?

Expand Messages | Collapse Messages