Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880253007: Remove flush_monomorphic_ics flag. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove flush_monomorphic_ics flag. Since v8:3629 is fixed, ICs and handlers do not retain objects. Committed: https://crrev.com/87c79df97382b55e936621809fb07a04e1dd1d6d Cr-Commit-Position: refs/heads/master@{#26455}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -23 lines) Patch
M src/heap/heap.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +2 lines, -11 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL https://codereview.chromium.org/880253007/diff/1/src/type-feedback-vector.cc File src/type-feedback-vector.cc (left): https://codereview.chromium.org/880253007/diff/1/src/type-feedback-vector.cc#oldcode138 src/type-feedback-vector.cc:138: // TODO(mvstanton): is this ic_age granular enough? it ...
5 years, 10 months ago (2015-02-05 09:44:16 UTC) #2
mvstanton
Fantastic! LGTM.
5 years, 10 months ago (2015-02-05 10:46:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880253007/1
5 years, 10 months ago (2015-02-05 11:21:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 11:45:45 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 11:46:01 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/87c79df97382b55e936621809fb07a04e1dd1d6d
Cr-Commit-Position: refs/heads/master@{#26455}

Powered by Google App Engine
This is Rietveld 408576698