Issue 880233002: Do not inline array push for arrays with dictionary mode elements.

Issue 880233002: Do not inline array push for arrays with dictionary mode elements. (Closed)

Created:
5 years, 10 months ago by Jarin

Modified:
5 years, 10 months ago

Reviewers:
mvstanton, danno

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Do not inline array push for arrays with dictionary mode elements. BUG=chromium:452878 LOG=n Committed: https://crrev.com/0cd991ebc01c3d32fd03e2abff340c31be3be668 Cr-Commit-Position: refs/heads/master@{#26357}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -21 lines)			Patch
M	src/hydrogen.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+15 lines, -18 lines	0 comments	Download
A +	test/mjsunit/array-push12.js	View	1 chunk	+10 lines, -3 lines	0 comments	Download

Total messages: 7 (2 generated)

Jarin

Could you take a look, please? The only thing that changed is the added !receiver_map->is_dictionary_map() ...

5 years, 10 months ago (2015-01-28 13:33:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880233002/1

5 years, 10 months ago (2015-01-30 13:49:55 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-01-30 13:51:50 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0cd991ebc01c3d32fd03e2abff340c31be3be668
Cr-Commit-Position: refs/heads/master@{#26357}