Add Array.prototype.reduce and .reduceRight.

Add ES5 Array methods reduce and reduceRight, with test.

[Lasse Reichstein, 2009-04-21 09:00:07]

Review, please.

[Dean McNamee, 2009-04-21 09:19:50]

http://codereview.chromium.org/88022/diff/1/2
File src/array.js (right):

http://codereview.chromium.org/88022/diff/1/2#newcode891
Line 891: find_initial: if (%_ArgumentsLength() < 2) {
I am missing why you need the label.

http://codereview.chromium.org/88022/diff/1/2#newcode892
Line 892: for (;i < length; i++) {
space after ;

http://codereview.chromium.org/88022/diff/1/2#newcode913
Line 913: throw MakeTypeError('called_non_callable', [ callback ]);
no spaces around [ ] (consistency with [])

[Christian Plesner Hansen, 2009-04-21 09:39:17]

Lgtm

http://codereview.chromium.org/88022/diff/1/2
File src/array.js (right):

http://codereview.chromium.org/88022/diff/1/2#newcode891
Line 891: find_initial: if (%_ArgumentsLength() < 2) {
I think the code style is

 find_initial:
  if (%_...)

http://codereview.chromium.org/88022/diff/1/4
File test/mjsunit/array-reduce.js (right):

http://codereview.chromium.org/88022/diff/1/4#newcode29
Line 29: * @fileoverview Test reduce and reduceRight
This is an excellent test!

[Lasse Reichstein, 2009-04-21 09:53:50]

Thanks for the comments.

http://codereview.chromium.org/88022/diff/1/2
File src/array.js (right):

http://codereview.chromium.org/88022/diff/1/2#newcode891
Line 891: find_initial: if (%_ArgumentsLength() < 2) {
I use the label to have a location to break to, to avoid executing the throw if
we don't find an element.

I preferred adding the label to the existing statement instead of creating
another block statement inside the if.

http://codereview.chromium.org/88022/diff/1/2#newcode891
Line 891: find_initial: if (%_ArgumentsLength() < 2) {
On 2009/04/21 09:39:17, Christian Plesner Hansen wrote:
> I think the code style is
> 
>  find_initial:
>   if (%_...)
> 

Done.

http://codereview.chromium.org/88022/diff/1/2#newcode892
Line 892: for (;i < length; i++) {
On 2009/04/21 09:19:50, Dean McNamee wrote:
> space after ;

Done.

http://codereview.chromium.org/88022/diff/1/2#newcode913
Line 913: throw MakeTypeError('called_non_callable', [ callback ]);
On 2009/04/21 09:19:50, Dean McNamee wrote:
> no spaces around [ ] (consistency with [])

Done.