Issue 880203006: Oilpan: fix build after r189148.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 880203006: Oilpan: fix build after r189148. (Closed)

Created:
5 years, 10 months ago by sof

Modified:
5 years, 10 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, krit, pdr+graphicswatchlist_chromium.org, Dominik Röttsches, dshwang, jbroman, slimming-paint-reviews_chromium.org, danakj, Rik, f(malita), Justin Novosad, blink-reviews-paint_chromium.org, Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: fix build after r189148. Rephrase FilterDisplayItem constructor to avoid unnecessary heap allocation of the FilterOperations part object. R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189173

Patch Set 1 #

Patch Set 2 : tidy up call site a bit further #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -16 lines)			Patch
M	Source/core/paint/FilterPainter.cpp	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	Source/platform/graphics/paint/FilterDisplayItem.h	View		1 chunk	+10 lines, -3 lines	0 comments	Download
M	Source/platform/graphics/paint/FilterDisplayItem.cpp	View		1 chunk	+13 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880203006/20001

5 years, 10 months ago (2015-01-29 07:29:09 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 08:56:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189173

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages