Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 880203003: Fix GN build for components/session_manager and /chromeos (Closed)

Created:
5 years, 11 months ago by Nikita (slow)
Modified:
5 years, 10 months ago
Reviewers:
Dmitry Polukhin, oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN build for components/session_manager and /chromeos BUG=None TEST=user_manager GN ninja build (debug|official; is_component_build=yes|no) TBR=oshima Committed: https://crrev.com/8d7d18d60478e740c9bc2423ec5e86e60e72164c Cr-Commit-Position: refs/heads/master@{#313479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chromeos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/session_manager/core/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Nikita (slow)
omnibox.mojom.js dbg gn build failure is reproduced on TOT and is discussed separately with sheriffs.
5 years, 11 months ago (2015-01-28 10:11:09 UTC) #2
Dmitry Polukhin
lgtm
5 years, 11 months ago (2015-01-28 10:20:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880203003/1
5 years, 11 months ago (2015-01-28 10:48:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38844)
5 years, 11 months ago (2015-01-28 10:53:49 UTC) #7
Nikita (slow)
TBR'ing oshima@ for chromeos/* owners review.
5 years, 11 months ago (2015-01-28 11:20:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880203003/1
5 years, 11 months ago (2015-01-28 11:21:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 11:25:41 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 11:26:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d7d18d60478e740c9bc2423ec5e86e60e72164c
Cr-Commit-Position: refs/heads/master@{#313479}

Powered by Google App Engine
This is Rietveld 408576698