Issue 8802017: Consider redirects to data:// urls as cancelling a request and don't report conflicts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8802017: Consider redirects to data:// urls as cancelling a request and don't report conflicts (Closed)

Created:
9 years ago by battre

Modified:
9 years ago

Reviewers:
Matt Perry

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr., aocampo

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Consider redirects to data:// urls as cancelling a request and don't report conflicts If an extension A tries to redirect a request to http://foo and an extension B tries to redirect a request to data://..., we consider the redirect of extension B as an attempt to cancel the request. As cancelling a request is considered to take precedence over redirects, this does not generate a conflict message any more. BUG=106431 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113068

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -21 lines)			Patch
	M	chrome/browser/extensions/extension_webrequest_api_helpers.cc	View		2 chunks	+55 lines, -21 lines	0 comments	Download
	M	chrome/browser/extensions/extension_webrequest_api_unittest.cc	View		1 chunk	+66 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

battre

I think this is a proper way to fix the merge conflicts brought up by ...

9 years ago (2011-12-05 19:49:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8802017/1

9 years ago (2011-12-05 21:52:48 UTC) #3

Change committed as 113068

Expand Messages | Collapse Messages