Add SSID getter to WiFiService

Add SSID getter to WiFiService.

The SSID is going to be displayed in the captive portal interstitial as such: "The network you are using (Google Guest)..."

BUG=451272
Committed: https://crrev.com/4770e8a571858a672cae59a4b818244df4520ac1
Cr-Commit-Position: refs/heads/master@{#313995}

[meacer, 2015-01-28 22:06:25]

meacer@chromium.org changed reviewers:
+ mef@chromium.org

[meacer, 2015-01-28 22:06:25]

mef: Can you PTAL?

[mef, 2015-01-28 22:41:38]

mef@chromium.org changed reviewers:
+ pneubeck@chromium.org

[mef, 2015-01-28 22:41:39]

Looks reasonable.

https://codereview.chromium.org/880143003/diff/40001/components/wifi/wifi_ser...
File components/wifi/wifi_service.h (right):

https://codereview.chromium.org/880143003/diff/40001/components/wifi/wifi_ser...
components/wifi/wifi_service.h:121: // Get the GUID of the currently connected
network, if any.
I think for UI presentation you should explicitly get SSID instead. Yes,
currently GUID is the same as SSID, but this is subject to change. Also,
apparently there are SSIDs that cannot be represented in utf-8
(https://code.google.com/p/chromium/issues/detail?id=432546).

pneubeck has introduced HexSSID and I'm planning to add support for that on Win
and Mac.

[meacer, 2015-01-29 22:38:27]

Thanks for the pointers, very useful. I've changed the patch to return SSID, but
without any non-UTF8 checks.
Instead, I'm doing a check where I'm using the SSID:
https://codereview.chromium.org/887573002/diff/80001/chrome/browser/ssl/capti...

[mef, 2015-01-30 17:45:41]

lgtm

https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
File components/wifi/wifi_service_mac.mm (right):

https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
components/wifi/wifi_service_mac.mm:423: *ssid =
base::SysNSStringToUTF8([interface_ bssid]);
I believe you need ssid, not bssid (which is essentially a MAC).

https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
File components/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
components/wifi/wifi_service_win.cc:818: error_code =
GetCurrentProperties(&connected_properties);
GetCurrentProperties may be a little overkill for this as it also gets list of
network's BSS using WlanGetNetworkBssList. 
I don't think it should cause any issues, but I would double-check that.

[meacer, 2015-01-30 19:11:50]

https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
File components/wifi/wifi_service_mac.mm (right):

https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
components/wifi/wifi_service_mac.mm:423: *ssid =
base::SysNSStringToUTF8([interface_ bssid]);
On 2015/01/30 17:45:41, mef wrote:
> I believe you need ssid, not bssid (which is essentially a MAC).

Done.

https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
File components/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
components/wifi/wifi_service_win.cc:818: error_code =
GetCurrentProperties(&connected_properties);
On 2015/01/30 17:45:41, mef wrote:
> GetCurrentProperties may be a little overkill for this as it also gets list of
> network's BSS using WlanGetNetworkBssList. 
> I don't think it should cause any issues, but I would double-check that.
> 

Added a lightweight version that doesn't use the BSS list: GetCurrentSSID.
Please let me know if you prefer this.

[mef, 2015-01-30 19:45:11]

still lgtm

https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
File components/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
components/wifi/wifi_service_win.cc:818: error_code =
GetCurrentProperties(&connected_properties);
On 2015/01/30 19:11:50, Mustafa Emre Acer wrote:
> On 2015/01/30 17:45:41, mef wrote:
> > GetCurrentProperties may be a little overkill for this as it also gets list
of
> > network's BSS using WlanGetNetworkBssList. 
> > I don't think it should cause any issues, but I would double-check that.
> > 
> 
> Added a lightweight version that doesn't use the BSS list: GetCurrentSSID.
> Please let me know if you prefer this.

Yeah, I think this has less performance concerns.

[meacer, 2015-01-30 20:10:06]

On 2015/01/30 19:45:11, mef wrote:
> still lgtm
> 
>
https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
> File components/wifi/wifi_service_win.cc (right):
> 
>
https://codereview.chromium.org/880143003/diff/60001/components/wifi/wifi_ser...
> components/wifi/wifi_service_win.cc:818: error_code =
> GetCurrentProperties(&connected_properties);
> On 2015/01/30 19:11:50, Mustafa Emre Acer wrote:
> > On 2015/01/30 17:45:41, mef wrote:
> > > GetCurrentProperties may be a little overkill for this as it also gets
list
> of
> > > network's BSS using WlanGetNetworkBssList. 
> > > I don't think it should cause any issues, but I would double-check that.
> > > 
> > 
> > Added a lightweight version that doesn't use the BSS list: GetCurrentSSID.
> > Please let me know if you prefer this.
> 
> Yeah, I think this has less performance concerns.

Will use this. Thanks!

[meacer, 2015-01-30 20:17:13]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2015-01-30 20:18:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880143003/80001

[commit-bot: I haz the power, 2015-01-30 21:16:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-30 21:17:55]

Patchset 5 (id:??) landed as
https://crrev.com/4770e8a571858a672cae59a4b818244df4520ac1
Cr-Commit-Position: refs/heads/master@{#313995}