Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 880143002: Remove skydb dependency on build/android/pylib (Closed)

Created:
5 years, 11 months ago by eseidel
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove skydb dependency on build/android/pylib I also fixed skydb to use --args-for sky_debugger to automatically issue the load from 'start' even when the --gdb option is present. I tried to invoke gdb_attach directly from within start_command but that seemed to cause some strangeness with my zsh shell where it would automatically suspend gdb. So I'll revisit that change in the next patch. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8feb05cdaa77caa096e89b473c8a582582621b23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -56 lines) Patch
M sky/tools/android_library_cacher.py View 3 chunks +7 lines, -3 lines 0 comments Download
M sky/tools/skydb View 16 chunks +44 lines, -53 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 11 months ago (2015-01-27 23:53:19 UTC) #1
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-27 23:56:09 UTC) #2
eseidel
5 years, 11 months ago (2015-01-27 23:56:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8feb05cdaa77caa096e89b473c8a582582621b23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698