Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 880133003: UAC and pin confirmation dialogs are not on foreground when updating pin # (Closed)

Created:
5 years, 11 months ago by weitao
Modified:
5 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UAC and pin confirmation dialogs are not on foreground when updating pin # In this change we elevate the me2me native messaging host before calling into the daemon controller for the tasks that requires elevation. The daemon controller still depends on the com component for those tasks but the elevation is now done in the me2me native messaging host itself. In followup CLs I will remove the elevated daemon controller com component and move its implementation to DaemonControllerDelegateWin. Note that the pin confirmation dialog is removed with this CL. This change has been approved by the chrome security team. BUG=447246 Committed: https://crrev.com/55c0c16b78bce6d968f1347e22cc404d75db5c82 Cr-Commit-Position: refs/heads/master@{#313545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M remoting/host/setup/me2me_native_messaging_host.cc View 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
weitao
PTAL
5 years, 11 months ago (2015-01-28 00:16:48 UTC) #2
Sergey Ulanov
lgtm
5 years, 11 months ago (2015-01-28 01:12:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880133003/1
5 years, 10 months ago (2015-01-28 17:50:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 18:41:36 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 18:43:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55c0c16b78bce6d968f1347e22cc404d75db5c82
Cr-Commit-Position: refs/heads/master@{#313545}

Powered by Google App Engine
This is Rietveld 408576698