Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880123004: Add hirono@ to chrome/browser/chromeos/extensions/file_manager/OWNERS. (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
satorux1
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, hirono
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add hirono@ to chrome/browser/chromeos/extensions/file_manager/OWNERS. BUG=None Committed: https://crrev.com/3fea0d5118e84a99887d5e7e7adc6ddbb6906b42 Cr-Commit-Position: refs/heads/master@{#313872}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove hidehiko@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/extensions/file_manager/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Steve McKay
Per our discussion.
5 years, 10 months ago (2015-01-30 04:41:30 UTC) #2
satorux1
lgtm with a request https://codereview.chromium.org/880123004/diff/1/chrome/browser/chromeos/extensions/file_manager/OWNERS File chrome/browser/chromeos/extensions/file_manager/OWNERS (right): https://codereview.chromium.org/880123004/diff/1/chrome/browser/chromeos/extensions/file_manager/OWNERS#newcode3 chrome/browser/chromeos/extensions/file_manager/OWNERS:3: hidehiko@chromium.org while you are at ...
5 years, 10 months ago (2015-01-30 04:48:56 UTC) #3
Steve McKay
Remove hidehiko@
5 years, 10 months ago (2015-01-30 04:51:59 UTC) #4
Steve McKay
https://codereview.chromium.org/880123004/diff/1/chrome/browser/chromeos/extensions/file_manager/OWNERS File chrome/browser/chromeos/extensions/file_manager/OWNERS (right): https://codereview.chromium.org/880123004/diff/1/chrome/browser/chromeos/extensions/file_manager/OWNERS#newcode3 chrome/browser/chromeos/extensions/file_manager/OWNERS:3: hidehiko@chromium.org On 2015/01/30 04:48:56, satorux1 wrote: > while you ...
5 years, 10 months ago (2015-01-30 04:52:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880123004/20001
5 years, 10 months ago (2015-01-30 04:53:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 05:39:27 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 05:40:17 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3fea0d5118e84a99887d5e7e7adc6ddbb6906b42
Cr-Commit-Position: refs/heads/master@{#313872}

Powered by Google App Engine
This is Rietveld 408576698