Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880123002: Move GuestView IPCs out of ExtensionMessageFilter to GuestViewMessageFilter (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GuestView IPCs out of ExtensionMessageFilter to GuestViewMessageFilter BUG=none Committed: https://crrev.com/ae92c1ca3455bea3985d80225b7545571055878b Cr-Commit-Position: refs/heads/master@{#313454}

Patch Set 1 #

Patch Set 2 : Updated GN file #

Patch Set 3 : Fixed AppShell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -110 lines) Patch
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/extension_message_filter.h View 2 chunks +0 lines, -11 lines 0 comments Download
M extensions/browser/extension_message_filter.cc View 5 chunks +0 lines, -99 lines 0 comments Download
A extensions/browser/guest_view/guest_view_message_filter.h View 1 chunk +81 lines, -0 lines 0 comments Download
A extensions/browser/guest_view/guest_view_message_filter.cc View 1 chunk +155 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_content_browser_client.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Fady Samuel
5 years, 11 months ago (2015-01-27 22:06:35 UTC) #2
not at google - send to devlin
lgtm
5 years, 11 months ago (2015-01-27 22:10:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880123002/1
5 years, 11 months ago (2015-01-27 22:12:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/2409) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/53625)
5 years, 10 months ago (2015-01-27 22:27:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880123002/20001
5 years, 10 months ago (2015-01-27 22:38:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/26488)
5 years, 10 months ago (2015-01-28 00:06:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880123002/40001
5 years, 10 months ago (2015-01-28 05:36:38 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-28 06:41:25 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 06:43:40 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ae92c1ca3455bea3985d80225b7545571055878b
Cr-Commit-Position: refs/heads/master@{#313454}

Powered by Google App Engine
This is Rietveld 408576698