Source/core/layout/LayoutTable.h - Issue 880113002: Fix crash when establishing an inline continuation inside a block continuation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutTable.h

Issue 880113002: Fix crash when establishing an inline continuation inside a block continuation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove assertion in LayoutTable::addChildIgnoringContinuation() - crashed fast/table/crash-bad-chil… Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/dynamic/insert-block-into-inline-beside-ex-spanner-table-column-expected.txt ('k') | Source/core/layout/LayoutTable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutTable.h

diff --git a/Source/core/layout/LayoutTable.h b/Source/core/layout/LayoutTable.h

index 511ef67a5d5549b7521883e27b11941aa5ad573f..1b868acbdb23a4823d32e1bf4d4c58b9f35f1117 100644

--- a/Source/core/layout/LayoutTable.h

+++ b/Source/core/layout/LayoutTable.h

@@ -123,6 +123,7 @@ public:

void recalcBordersInRowDirection();

virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0) override;

+ virtual void addChildIgnoringContinuation(RenderObject* newChild, RenderObject* beforeChild = 0) override;

struct ColumnStruct {

explicit ColumnStruct(unsigned initialSpan = 1)