Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: Source/core/layout/LayoutTable.cpp

Issue 880113002: Fix crash when establishing an inline continuation inside a block continuation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: code review Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutTable.cpp
diff --git a/Source/core/layout/LayoutTable.cpp b/Source/core/layout/LayoutTable.cpp
index ae01460b50ad69914093e7b83218b2997be0bc7e..ac388f13b96eaf339ba2a02f6769240ce601770f 100644
--- a/Source/core/layout/LayoutTable.cpp
+++ b/Source/core/layout/LayoutTable.cpp
@@ -207,6 +207,14 @@ void LayoutTable::addChild(RenderObject* child, RenderObject* beforeChild)
section->addChild(child);
}
+void LayoutTable::addChildIgnoringContinuation(RenderObject* newChild, RenderObject* beforeChild)
+{
+ // Tables cannot be continuations. More importantly, we need to bypass the RenderBlock
+ // implementation and instead do a normal addChild(), so that any missing anonymous table part
+ // renderers are inserted.
+ addChild(newChild, beforeChild);
+}
+
void LayoutTable::addCaption(const LayoutTableCaption* caption)
{
ASSERT(m_captions.find(caption) == kNotFound);

Powered by Google App Engine
This is Rietveld 408576698