LayoutTests/fast/multicol/dynamic/insert-block-into-inline-beside-ex-spanner-table-column.html - Issue 880113002: Fix crash when establishing an inline continuation inside a block continuation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/dynamic/insert-block-into-inline-beside-ex-spanner-table-column.html

Issue 880113002: Fix crash when establishing an inline continuation inside a block continuation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove assertion in LayoutTable::addChildIgnoringContinuation() - crashed fast/table/crash-bad-chil… Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/dynamic/block-with-spanner-and-inline-and-table-column-expected.txt ('k') | LayoutTests/fast/multicol/dynamic/insert-block-into-inline-beside-ex-spanner-table-column-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner)

	4 testRunner.dumpAsText();

	5 </script>

	6 <p>With a multicol container that has a block and with a spanner inside, do the following:</p>

	7 <ol>

	8 <li>Insert an inline right before the spanner</li>

	9 <li>Turn the spanner into a table-column</li>

	10 <li>Insert an inline child into the previously inserted inline</li>

	11 <li>Set column-span:none on the ex-spanner (now table-column)</li>

	12 <li>Insert a block into the previously inserted inline child</li>

	13 </ol>

	14 <p>The word 'PASS' should be seen below.</p>

	15 <div style="-webkit-column-count:2;">

	16 <div>

	17 <span id="inline" style="display:none;">

	18 <emph id="tCF74" style="display:none;">

	19 <footer id="tCF33" style="display:none;">PASS</footer>

	20 </emph>

	21 </span>

	22 <div id="spanner" style="-webkit-column-span:all;"></div>

	23 </div>

	24 </div>

	25

	26 <script>

	27 document.body.offsetTop;

	28 document.getElementById("inline").style.display = "inline";

	29

	30 // Note that a table-column isn't allowed to become a spanner.

	31 document.getElementById("spanner").style.display = "table-column";

	32

	33 document.body.offsetTop;

	34 tCF74.style.display = '';

	35 document.getElementById("spanner").style.webkitColumnSpan = "none";

	36 tCF33.style.display = '';

	37 </script>

OLD	NEW