Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 880093002: Expose --site-per-process in chrome://flags (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose --site-per-process in chrome://flags BUG=99379 Committed: https://crrev.com/e52b234b38b4757408fa13364c283002bedfbcd6 Cr-Commit-Position: refs/heads/master@{#313385}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update description wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
The main motivation for this is to make it easier to test OOPIF in CrOS ...
5 years, 11 months ago (2015-01-27 21:01:08 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 11 months ago (2015-01-27 21:02:11 UTC) #3
Charlie Reis
LGTM with nit. I might have preferred mentioning Site Isolation in the description, but it's ...
5 years, 11 months ago (2015-01-27 21:43:28 UTC) #5
dcheng
https://codereview.chromium.org/880093002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/880093002/diff/1/chrome/app/generated_resources.grd#newcode14333 chrome/app/generated_resources.grd:14333: + Highly experimental support for rendering iframes in separate ...
5 years, 11 months ago (2015-01-27 21:44:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880093002/20001
5 years, 11 months ago (2015-01-27 21:45:30 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 22:46:15 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 22:48:12 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e52b234b38b4757408fa13364c283002bedfbcd6
Cr-Commit-Position: refs/heads/master@{#313385}

Powered by Google App Engine
This is Rietveld 408576698