Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 880083005: Reland Device Orientation API on Chrome OS (Closed)

Created:
5 years, 10 months ago by jonross
Modified:
5 years, 10 months ago
Reviewers:
jam, timvolodine
CC:
chromium-reviews, riju_, Michael van Ouwerkerk, jam, timvolodine, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Device Orientation API on Chrome OS This reverts commit cc6a8bfeb49e93068e8df28f406e6ad0b5d6915e. From review: https://codereview.chromium.org/899973002/ Original issue's description: > Device Orientation API on Chrome OS > > Implement DataFetcherSharedMemory on Chrome OS to provide Device Orientation support. Create SensorManagerChromeOS to observe accelerometer events, and to generate updates to the Device Orientation API. > > This is a follow up to: https://codereview.chromium.org/680383007/ > > With the accelerometer on Chrome OS now exposed to content/ from chromeos/accelerometer, no ash/ implementation is required. No public api in content/public/browser is needed either. > > TEST=SensorManagerTest.OrientationBuffer, SensorManagerTest.NeutralOrientation, SensorManagerTest.UpsideDown, SensorManagerTest.BeforeUpsideDownBoundary, SensorManagerTest.LeftEdge, SensorManagerTest.RightEdge, SensorManagerTest.BeforeRightEdgeBoundary > BUG=342908 TBR=timvolodine@chromium.org,jam@chromium.org BUG=342908 Committed: https://crrev.com/a6725f19e83a67b453db83f15c4191b2785de60a Cr-Commit-Position: refs/heads/master@{#314692}

Patch Set 1 #

Patch Set 2 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -2 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory.h View 2 chunks +7 lines, -2 lines 0 comments Download
A content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A content/browser/device_sensors/sensor_manager_chromeos.h View 1 chunk +55 lines, -0 lines 0 comments Download
A content/browser/device_sensors/sensor_manager_chromeos.cc View 1 1 chunk +121 lines, -0 lines 0 comments Download
A content/browser/device_sensors/sensor_manager_chromeos_unittest.cc View 1 chunk +151 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +4 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880083005/20001
5 years, 10 months ago (2015-02-04 23:22:26 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 00:53:21 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 00:55:32 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6725f19e83a67b453db83f15c4191b2785de60a
Cr-Commit-Position: refs/heads/master@{#314692}

Powered by Google App Engine
This is Rietveld 408576698