Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 880083004: Change which manifest and resources are passed to lint.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/lint.py ('k') | build/android/lint_action.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 <ignore path="chrome/android/java/res/drawable-xxhdpi"/> 48 <ignore path="chrome/android/java/res/drawable-xxhdpi"/>
49 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/> 49 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/>
50 <ignore path="ui/android/java/res/drawable-xxhdpi"/> 50 <ignore path="ui/android/java/res/drawable-xxhdpi"/>
51 <ignore path="ui/android/java/res/drawable-xxxhdpi"/> 51 <ignore path="ui/android/java/res/drawable-xxxhdpi"/>
52 </issue> 52 </issue>
53 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. --> 53 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. -->
54 <issue id="IconLocation"> 54 <issue id="IconLocation">
55 <ignore path="content/shell/android/java/res/"/> 55 <ignore path="content/shell/android/java/res/"/>
56 <ignore path="chrome/android/shell/res/"/> 56 <ignore path="chrome/android/shell/res/"/>
57 </issue> 57 </issue>
58 <issue id="InconsistentLayout" severity="ignore"/>
59 <issue id="InflateParams" severity="ignore"/>
58 <issue id="MissingApplicationIcon" severity="ignore"/> 60 <issue id="MissingApplicationIcon" severity="ignore"/>
59 <issue id="MissingRegistered" severity="ignore"/> 61 <issue id="MissingRegistered" severity="ignore"/>
60 <issue id="MissingVersion"> 62 <issue id="MissingVersion">
61 <ignore path="AndroidManifest.xml"/> 63 <ignore path="AndroidManifest.xml"/>
62 </issue> 64 </issue>
63 <!-- Disabling is InlinedApi and NewApi is bad but we have too many of these e rrors and nobody is fixing it. crbug.com/411461 --> 65 <!-- Disabling is InlinedApi and NewApi is bad but we have too many of these e rrors and nobody is fixing it. crbug.com/411461 -->
64 <issue id="InlinedApi" severity="ignore"/> 66 <issue id="InlinedApi" severity="ignore"/>
65 <issue id="NewApi" severity="ignore"/> 67 <issue id="NewApi" severity="ignore"/>
66 <issue id="OldTargetApi"> 68 <issue id="OldTargetApi">
67 <ignore path="AndroidManifest.xml"/> 69 <ignore path="AndroidManifest.xml"/>
68 </issue> 70 </issue>
69 <issue id="Overdraw" severity="ignore"/> 71 <issue id="Overdraw" severity="ignore"/>
70 <issue id="Recycle" severity="ignore"/> 72 <issue id="Recycle" severity="ignore"/>
71 <issue id="Registered" severity="ignore"/> 73 <issue id="Registered" severity="ignore"/>
74 <issue id="RtlCompat" severity="ignore"/>
72 <issue id="RtlEnabled" severity="ignore"/> 75 <issue id="RtlEnabled" severity="ignore"/>
76 <issue id="RtlSymmetry" severity="ignore"/>
73 <issue id="SdCardPath"> 77 <issue id="SdCardPath">
74 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/> 78 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/>
75 </issue> 79 </issue>
76 <issue id="SetJavaScriptEnabled" severity="ignore"/> 80 <issue id="SetJavaScriptEnabled" severity="ignore"/>
77 <issue id="UnusedResources"> 81 <issue id="UnusedResources">
78 <!-- TODO(aurimas): remove suppression once crbug.com/458328 is fixed. --> 82 <!-- TODO(aurimas): remove suppression once crbug.com/458328 is fixed. -->
79 <ignore path="content/public/android/java/res/layout/validation_message_bubb le.xml" /> 83 <ignore path="content/public/android/java/res/layout/validation_message_bubb le.xml" />
80 84
81 <!-- These files are used by chrome_shell_apk and chrome_apk targets. --> 85 <!-- These files are used by chrome_shell_apk and chrome_apk targets. -->
82 <ignore path="chrome/android/java/res/layout/accessibility_tab_switcher.xml" /> 86 <ignore path="chrome/android/java/res/layout/accessibility_tab_switcher.xml" />
83 <ignore path="chrome/android/java/res/drawable/btn_back.xml" /> 87 <ignore path="chrome/android/java/res/drawable/btn_back.xml" />
84 <ignore path="chrome/android/java/res/drawable/btn_forward.xml" /> 88 <ignore path="chrome/android/java/res/drawable/btn_forward.xml" />
85 </issue> 89 </issue>
90 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
91 <issue id="UnusedAttribute" severity="ignore"/>
86 <issue id="ViewConstructor" severity="ignore"/> 92 <issue id="ViewConstructor" severity="ignore"/>
87 <issue id="WrongCall" severity="ignore"/> 93 <issue id="WrongCall" severity="ignore"/>
88 </lint> 94 </lint>
OLDNEW
« no previous file with comments | « build/android/gyp/lint.py ('k') | build/android/lint_action.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698