Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 880083002: Revert of [Chromoting] Enable AppRemoting sample apps by default in all.gyp. (Closed)

Created:
5 years, 11 months ago by brettw
Modified:
5 years, 11 months ago
Reviewers:
garykac, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromoting] Enable AppRemoting sample apps by default in all.gyp. (patchset #4 id:60001 of https://codereview.chromium.org/878793003/) Reason for revert: Broke the official builders: Traceback (most recent call last): File "../remoting/webapp/build-webapp.py", line 413, in <module> sys.exit(main()) File "../remoting/webapp/build-webapp.py", line 409, in main service_environment) File "../remoting/webapp/build-webapp.py", line 198, in buildWebApp + buildtype + ': ' + service_environment) Exception: Invalid service_environment targeted for Official: dev ninja: build stopped: subcommand failed. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/55334/steps/compile/logs/stdio#error1 Original issue's description: > [Chromoting] Enable AppRemoting sample apps by default in all.gyp. > > Where "by default" = whenever we build Chromoting. > > BUG= > > Committed: https://crrev.com/e0bf65f1e2fcd3515b92c1b49f04aa30fd0d47e6 > Cr-Commit-Position: refs/heads/master@{#313324} TBR=scottmg@chromium.org,garykac@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/aef028b08a623095942ff35a36cada39fc4e49e1 Cr-Commit-Position: refs/heads/master@{#313346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
Created Revert of [Chromoting] Enable AppRemoting sample apps by default in all.gyp.
5 years, 11 months ago (2015-01-27 20:29:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880083002/1
5 years, 11 months ago (2015-01-27 20:30:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 20:31:26 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:32:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aef028b08a623095942ff35a36cada39fc4e49e1
Cr-Commit-Position: refs/heads/master@{#313346}

Powered by Google App Engine
This is Rietveld 408576698