Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: extensions/common/api/networking_config.idl

Issue 880073002: Networking.config: Implementation of the NetworkingConfigService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moved & renamed apitest Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/api/_permission_features.json ('k') | extensions/common/api/schemas.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/networking_config.idl
diff --git a/chrome/common/extensions/api/networking_config.idl b/extensions/common/api/networking_config.idl
similarity index 82%
rename from chrome/common/extensions/api/networking_config.idl
rename to extensions/common/api/networking_config.idl
index ea4c4321b76495e927efe4ec5e57d2cc3a2a6bd2..2ba289ccaf4e645bbcda774b8539e2bd71eaedc2 100644
--- a/chrome/common/extensions/api/networking_config.idl
+++ b/extensions/common/api/networking_config.idl
@@ -49,6 +49,13 @@ namespace networking.config {
failed
};
+ // Invoked by $(setNetworkFilter) when the respective operation is finished.
+ callback SetNetworkFilterCallback = void();
+
+ // Invoked by $(finishAuthentication) when the respective operation is
+ // finished.
+ callback FinishAuthenticationCallback = void();
+
interface Functions {
// Allows an extension to define network filters for the networks it can
// handle. A call to this function will remove all filters previously
@@ -56,16 +63,20 @@ namespace networking.config {
// |networks|: Network filters to set. Every <code>NetworkInfo</code> must
// either have the <code>SSID</code> or <code>HexSSID</code>
// set. Other fields will be ignored.
- void setNetworkFilter(NetworkInfo[] networks);
+ // |callback|: Called back when this operation is finished.
+ void setNetworkFilter(NetworkInfo[] networks,
+ SetNetworkFilterCallback callback);
// Called by the extension to notify the network config API that it finished
// a captive portal authentication attempt and hand over the result of the
// attempt. This function must only be called with the GUID of the latest
// $(onCaptivePortalDetected) event.
- // |GUID|: unique network identifier obtained from
+ // |GUID|: Unique network identifier obtained from
// $(onCaptivePortalDetected).
- // |result|: the result of the authentication attempt
- void finishAuthentication(DOMString GUID, AuthenticationResult result);
+ // |result|: The result of the authentication attempt.
+ // |callback|: Called back when this operation is finished.
+ void finishAuthentication(DOMString GUID, AuthenticationResult result,
+ FinishAuthenticationCallback callback);
};
interface Events {
« no previous file with comments | « extensions/common/api/_permission_features.json ('k') | extensions/common/api/schemas.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698